Conversation
|
Thanks for the work here. There is useful progress in this branch, but this PR should be split before merge. Right now it is too broad to review safely: 28 changed files, ~4k additions, and several distinct concerns bundled together. In particular, it mixes:
These are not one review unit. Some are core workflow changes, some are reliability improvements, some are writing-package features, and some are a substantial architectural expansion. Reviewing them together makes it hard to reason about regressions, approve only the good parts, or maintain a clear project direction. Suggested split:
Please keep each split PR narrowly scoped, with its own motivation, tests, and validation. In the current form, this is too much surface area for one merge. |
|
@yyifan-onyan |
Code ReviewI agree with @black-yt's suggestion to split this PR — 28 files and ~4k additions across multiple unrelated concerns is too much surface area for a single review. Beyond the split, there's a larger issue: most of the core functionality in this PR has already landed on main through other PRs. Already on main
These portions would conflict heavily on rebase and would essentially be duplicated work. What's actually new
Concerns about
|
|
Thank you for your contribution. This PR has been superseded by your newer PR, so we are closing it. |
Summary
This PR turns the branch into a pure CLI-first AutoR workflow runner with stronger workflow state management, richer platform-alignment modules, and production-oriented stage 07/08 packaging.
The branch keeps
main.pyas the run entrypoint,src/manager.pyas the 8-stage orchestrator with human approval gates,src/operator.pyas the Claude Code executor, andsrc/utils.pyas the run-layout/prompt/validation layer. Runs still live underruns/<run_id>/, with stage drafts written tostages/*.tmp.mdbefore validation and promotion.TODO Status
Status: Done
What landed:
--rollback-stageCLI supportstalepending/dirtyStatus: Done
What landed:
run_manifest.jsonas the primary machine-readable state sourceStatus: Done
What landed:
operator_state/operator_state/Status: Done
What landed:
handoff/<stage>.mdsummaries for approved stagesStatus: Not done
Note:
Status: Not done
Note:
Status: Done
What landed:
.tex, bibliography, tables, figure manifest, build script, submission checklist, and compiled PDF placeholder artifactsStatus: Done
What landed:
Status: Not done by design
Note:
Status: Partially done
What landed:
What is still missing:
Additional Notes
run_state.jsonfile dependency has been removed;run_manifest.jsonis now the sole persisted workflow state source.src/run_state.pyremains only as an in-memory compatibility formatter/adapter derived from the manifest.Validation
python -m py_compile main.py src/*.py src/platform/*.py tests/*.pypython -m unittest discover -s tests -v